linux-kernel - Re: [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2022 15:04:41 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config
 files

On 9/18/22 23:01, Lukas Bulwahn wrote:
> SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly,
> i.e., RAID_ATTRS needs to be m when SCSI=m.
> 
> This helper config symbol SCSI_MOD still shows up even in kernel
> configurations that do not select the block subsystem and where SCSI is
> not even a configuration option mentioned and selectable.
> 
> Make this SCSI_MOD depend on BLOCK, so that it only shows up when it is
> slightly relevant in the kernel configuration.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>   drivers/scsi/Kconfig | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 955cb69a5418..03e71e3d5e5b 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -2,9 +2,10 @@
>   menu "SCSI device support"
>   
>   config SCSI_MOD
> -       tristate
> -       default y if SCSI=n || SCSI=y
> -       default m if SCSI=m
> +	tristate
> +	default y if SCSI=n || SCSI=y
> +	default m if SCSI=m
> +	depends on BLOCK

Reviewed-by: Bart Van Assche <bvanassche@....org>