linux-kernel - Re: [EXT] Re: [PATCH v3 1/1] tracing: Fix compile error in trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86d9d0f8-ae29-3875-cbf1-b609f4f59421@marvell.com>
Date:   Thu, 22 Sep 2022 15:34:12 -0700
From:   Arun Easi <aeasi@...vell.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        James Bottomley <jejb@...ux.ibm.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-next@...r.kernel.org>,
        <GR-QLogic-Storage-Upstream@...vell.com>
Subject: Re: [EXT] Re: [PATCH v3 1/1] tracing: Fix compile error in trace_array
 calls when TRACING is disabled

Thanks for the review, Steve.

Regards,
-Arun

On Thu, 22 Sep 2022, 2:02pm, Steven Rostedt wrote:

> External Email
> 
> ----------------------------------------------------------------------
> On Thu, 15 Sep 2022 21:32:59 -0400
> "Martin K. Petersen" <martin.petersen@...cle.com> wrote:
> 
> > Steven,
> > 
> > Can you please review Arun's patch?
> 
> Sorry, was busy running a conference ;-)
> 
> > 
> > > Fix this compilation error seen when CONFIG_TRACING is not enabled:
> > >
> > > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init':
> > > drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function
> > > 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'?
> > > [-Werror=implicit-function-declaration]
> > >  2854 |         qla_trc_array = trace_array_get_by_name("qla2xxx");
> > >       |                         ^~~~~~~~~~~~~~~~~~~~~~~
> > >       |                         trace_array_set_clr_event
> > >
> > > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_uninit':
> > > drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function
> > > 'trace_array_put' [-Werror=implicit-function-declaration]
> > >  2869 |         trace_array_put(qla_trc_array);
> > >       |         ^~~~~~~~~~~~~~~
> > >  
> > 
> 
> The patch looks good to me.
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> 
> -- Steve
>