linux-kernel - Re: [PATCH 2/2] tracing: Use proper do_arch_spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YywU8U7yD1nvvGlZ@hirez.programming.kicks-ass.net>
Date:   Thu, 22 Sep 2022 09:55:29 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Waiman Long <longman@...hat.com>, Ingo Molnar <mingo@...hat.com>,
        Will Deacon <will@...nel.org>,
        Boqun Feng <boqun.feng@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] tracing: Use proper do_arch_spin_lock() API


I'm with Steve on not adding wrappers for this; people that use
arch_spinlock_* get to keep the pieces :-)

On Wed, Sep 21, 2022 at 06:17:21PM -0400, Steven Rostedt wrote:

> > @@ -1819,7 +1819,7 @@ update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu,
> >  		return;
> >  	}
> >  
> > -	arch_spin_lock(&tr->max_lock);
> > +	do_arch_spin_lock(&tr->max_lock);
> 
> Nothing here is needed, as interrupts had better be disabled when this
> function is called. And there's already a:
> 
> 	WARN_ON_ONCE(!irqs_disabled());

You can write that as lockdep_assert_irqs_disabled();