linux-kernel - Re: [PATCH net-next 0/2] net: phy: mxl-gpy: Add mode for 2 leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2022 10:05:29 +0200
From:   Michael Walle <michael@...le.cc>
To:     marcus.carlberg@...s.com
Cc:     andrew@...n.ch, davem@...emloft.net, devicetree@...r.kernel.org,
        edumazet@...gle.com, hkallweit1@...il.com, kernel@...s.com,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        linux@...linux.org.uk, lxu@...linear.com, netdev@...r.kernel.org,
        pabeni@...hat.com, Michael Walle <michael@...le.cc>
Subject: Re: [PATCH net-next 0/2] net: phy: mxl-gpy: Add mode for 2 leds

Hi,

> GPY211 phy default to using all four led pins.
> Hardwares using only two leds where led0 is used as the high
> network speed led and led1 the low network speed led will not
> get the correct behaviour since 1Gbit and 2.5Gbit will not be
> represented at all in the existing leds.

I might be wrong, but PHY LED bindings should be integrated with/using
the LED subsystem. Although I didn't see any development regarding this
for a long time.

That being said, it seems you are adding a new (DT) property which
just matches your particular hardware design, no?

-michael