linux-kernel - RE: [PATCH v4 1/6] iommu/msm: Fix error-out routine in msm_iommu_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB52762E13C04F703C4BBB2D8E8C4E9@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Thu, 22 Sep 2022 08:08:48 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Nicolin Chen <nicolinc@...dia.com>,
        "agross@...nel.org" <agross@...nel.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "konrad.dybcio@...ainline.org" <konrad.dybcio@...ainline.org>,
        "joro@...tes.org" <joro@...tes.org>,
        "will@...nel.org" <will@...nel.org>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "sricharan@...eaurora.org" <sricharan@...eaurora.org>
CC:     "jgg@...dia.com" <jgg@...dia.com>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 1/6] iommu/msm: Fix error-out routine in
 msm_iommu_attach_dev()

> From: Nicolin Chen <nicolinc@...dia.com>
> Sent: Wednesday, September 21, 2022 4:23 PM
> 
> The error-out routine is missing all the reverting pieces for the iop and
> attached-ctx allocations. And clock enable/disable is unbalanced too.
> 
> Fix it by adding __disable_clocks() and calling msm_iommu_detach_dev() at
> the end of the msm_iommu_attach_dev() if "ret" is non-zero. Also set the
> master->num to 0 in the detach_dev() since attach_dev() would check it.
> 
> Fixes: 109bd48ea2e1 ("iommu/msm: Add DT adaptation")
> Cc: stable@...r.kernel.org
> Cc: Sricharan R <sricharan@...eaurora.org>
> Cc: Andy Gross <agross@...nel.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Konrad Dybcio <konrad.dybcio@...ainline.org>
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>