linux-kernel - Re: [PATCH 0/3] fix error when writing negative value to simple attribute files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220922080648.254312-1-zhaogongyi@huawei.com>
Date:   Thu, 22 Sep 2022 16:06:48 +0800
From:   Zhao Gongyi <zhaogongyi@...wei.com>
To:     <akinobu.mita@...il.com>
CC:     <akpm@...ux-foundation.org>, <corbet@....net>, <david@...hat.com>,
        <gregkh@...uxfoundation.org>, <linux-doc@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-kselftest@...r.kernel.org>, <linux-mm@...ck.org>,
        <osalvador@...e.de>, <rafael@...nel.org>, <shuah@...nel.org>,
        <viro@...iv.linux.org.uk>, <weiyongjun1@...wei.com>,
        <yangyicong@...ilicon.com>, <zhaogongyi@...wei.com>
Subject: Re: [PATCH 0/3] fix error when writing negative value to simple attribute files

On Tue, 20 Sep 2022 02:24:15 +0900
Akinobu Mita <akinobu.mita@...il.com> wrote:
> The simple attribute files do not accept a negative value since the
> commit 488dac0c9237 ("libfs: fix error cast of negative value in
> simple_attr_write()"), but some attribute files want to accept
> a negative value.
> 
> Akinobu Mita (3):
>   libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
>   lib/notifier-error-inject: fix error when writing -errno to debugfs
>     file
>   debugfs: fix error when writing negative value to atomic_t debugfs
>     file
> 
>  .../fault-injection/fault-injection.rst       | 10 +++----
>  fs/debugfs/file.c                             | 28 +++++++++++++++----
>  fs/libfs.c                                    | 22 +++++++++++++--
>  include/linux/debugfs.h                       | 19 +++++++++++--
>  include/linux/fs.h                            | 12 ++++++--
>  lib/notifier-error-inject.c                   |  2 +-
>  6 files changed, 73 insertions(+), 20 deletions(-)

I have tested this version, it is ok.

Tested-by: Zhao Gongyi <zhaogongyi@...wei.com>