linux-kernel - Re: [PATCH] rv/monitor: add __init/__exit annotations to module init/exit funcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <468b3d61-a1a9-a49b-b737-c2d39ca22a4e@huawei.com>
Date:   Thu, 22 Sep 2022 18:37:52 +0800
From:   xiujianfeng <xiujianfeng@...wei.com>
To:     Daniel Bristot de Oliveira <bristot@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, <rostedt@...dmis.org>,
        <mingo@...hat.com>
Subject: Re: [PATCH] rv/monitor: add __init/__exit annotations to module
 init/exit funcs

Hi,

在 2022/9/22 17:25, Daniel Bristot de Oliveira 写道:
> Hi Xiu
> 
> The first char after the subsys: must be capital, i.e.,
> 
> [PATCH] rv/monitor: Add __init/__exit annotations to module init/exit funcs
> 
> On 9/11/22 05:04, Xiu Jianfeng wrote:
>> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Please, also add these tags to the monitor templates here:
> 
> 
> tools/verification/dot2/dot2k_templates/main_global.c
> tools/verification/dot2/dot2k_templates/main_per_cpu.c
> tools/verification/dot2/dot2k_templates/main_per_task.c
> 
> So the fix is propagated to future monitors.

Thanks for the review, will do in v2.

> 
> Thanks
> -- Daniel
> .
>