lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Sep 2022 14:33:47 +0300 From: Adrian Hunter <adrian.hunter@...el.com> To: Prathamesh Shete <pshete@...dia.com>, ulf.hansson@...aro.org, thierry.reding@...il.com, jonathanh@...dia.com, p.zabel@...gutronix.de, linux-mmc@...r.kernel.org, linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org Cc: anrao@...dia.com, smangipudi@...dia.com, kyarlagadda@...dia.com Subject: Re: [PATCH v3 4/4] mmc: sdhci-tegra: Use actual clock rate for SW tuning correction On 20/09/22 15:37, Prathamesh Shete wrote: > Ensure tegra_host member "curr_clk_rate" holds the actual clock rate > instead of requested clock rate for proper use during tuning correction > algorithm. Actual clk rate may not be the same as the requested clk > frequency depending on the parent clock source set. Tuning correction > algorithm depends on certain parameters which are sensitive to current > clk rate. If the host clk is selected instead of the actual clock rate, > tuning correction algorithm may end up applying invalid correction, > which could result in errors > > Fixes: ea8fc5953e8b ("mmc: tegra: update hw tuning process") > > Signed-off-by: Aniruddha TVS Rao <anrao@...dia.com> > Signed-off-by: Prathamesh Shete <pshete@...dia.com> Acked-by: Adrian Hunter <adrian.hunter@...el.com> > --- > drivers/mmc/host/sdhci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 58449e010a9b..10f6df070456 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -780,7 +780,7 @@ static void tegra_sdhci_set_clock(struct sdhci_host *host, unsigned int clock) > dev_err(dev, "failed to set clk rate to %luHz: %d\n", > host_clk, err); > > - tegra_host->curr_clk_rate = host_clk; > + tegra_host->curr_clk_rate = clk_get_rate(pltfm_host->clk); > if (tegra_host->ddr_signaling) > host->max_clk = host_clk; > else
Powered by blists - more mailing lists