linux-kernel - Re: [PATCH] xhci: print warning when HCE was set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b5a45f1-caf3-4259-77da-e36788f5b8a9@linux.intel.com>
Date:   Thu, 22 Sep 2022 16:01:58 +0300
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Longfang Liu <liulongfang@...wei.com>, gregkh@...uxfoundation.org,
        mathias.nyman@...el.com
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        yisen.zhuang@...wei.com
Subject: Re: [PATCH] xhci: print warning when HCE was set

Hi

On 15.9.2022 4.11, Longfang Liu wrote:
> When HCE(Host Controller Error) is set, it means that the xhci hardware
> controller has an error at this time, but the current xhci driver
> software does not log this event.
> 
> By adding an HCE event detection in the xhci interrupt processing
> interface, a warning log is output to the system, which is convenient
> for system device status tracking.
> 

xHC should cease all activity when it sets HCE, and is probably not
generating interrupts anymore.

Would probably be more useful to check for HCE at timeouts than in the
interrupt handler.

If this is something seen on actual hardware then it makes sense to add it.

Thanks
-Mathias