lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Sep 2022 13:02:05 +0000 From: Sakari Ailus <sakari.ailus@...ux.intel.com> To: "Lad, Prabhakar" <prabhakar.csengg@...il.com> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Philipp Zabel <p.zabel@...gutronix.de>, Jacopo Mondi <jacopo@...ndi.org>, Niklas Söderlund <niklas.soderlund@...natech.se>, Hans Verkuil <hverkuil-cisco@...all.nl>, Geert Uytterhoeven <geert+renesas@...der.be>, linux-media@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com> Subject: Re: [PATCH v2 3/4] media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver Hi Prabhakar, On Thu, Sep 22, 2022 at 01:53:49PM +0100, Lad, Prabhakar wrote: > > > +int rzg2l_csi2_cmn_rstb_deassert(struct rzg2l_csi2 *csi2); > > > +int rzg2l_csi2_dphy_setting(struct rzg2l_csi2 *csi2, bool on); > > > +void rzg2l_csi2_mipi_link_setting(struct rzg2l_csi2 *csi2, bool on); > > > > Are these something that could be achieved using the standard interfaces, > > as I believe the other drivers are doing? The pre_streamon and > > post_streamon callbacks could be relevant for this. > > > Thanks for the pointer. I have now moved some code to pre_streamon () > and rest to s_stream(). Is there any mandatory rule to have both > implemented? (as I wont be needing post_streamoff(), nothing complains > so for) In principle no. But if you e.g. resume the device in pre_streamon, you'll need to suspend it in post_streamon. -- Sakari Ailus
Powered by blists - more mailing lists