linux-kernel - Re: [PATCH v4 1/7] scsi: libsas: Add sas_ata_device_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f336809-d594-8ee5-f3bd-4393730cd01a@huawei.com>
Date:   Thu, 22 Sep 2022 21:51:23 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     John Garry <john.garry@...wei.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <jinpu.wang@...ud.ionos.com>,
        <damien.lemoal@...nsource.wdc.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <yangxingui@...wei.com>
Subject: Re: [PATCH v4 1/7] scsi: libsas: Add sas_ata_device_link_abort()


On 2022/9/22 17:46, John Garry wrote:
> Similar to how AHCI handles NCQ errors in ahci_error_intr() ->
> ata_port_abort() -> ata_do_link_abort(), add an NCQ error handler for LLDDs
> to call to initiate a link abort.
> 
> This will mark all outstanding QCs as failed and kick-off EH.
> 
> Note:
> A "force reset" argument is added for drivers which require the ATA error
> handling to always reset the device.
> 
> A driver may require this feature for when SATA device per-SCSI cmnd
> resources are only released during reset for ATA EH. As such, we need an
> option to force reset to be done, regardless of what any EH autopsy
> decides.
> 
> Suggested-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
> Signed-off-by: John Garry <john.garry@...wei.com>
> Tested-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
> ---
>   drivers/scsi/libsas/sas_ata.c | 12 ++++++++++++
>   include/scsi/sas_ata.h        |  6 ++++++
>   2 files changed, 18 insertions(+)

Reviewed-by: Jason Yan <yanaijie@...wei.com>