linux-kernel - Re: [PATCH 2/2] ACPI: PCC: fix Tx done interface in handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3af017ce-87fb-168d-9ef0-60c7a43487a3@huawei.com>
Date:   Thu, 22 Sep 2022 10:30:50 +0800
From:   "lihuisong (C)" <lihuisong@...wei.com>
To:     Sudeep Holla <sudeep.holla@....com>
CC:     <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <rafael@...nel.org>, <rafael.j.wysocki@...el.com>,
        <wanghuiqiang@...wei.com>, <huangdaode@...wei.com>
Subject: Re: [PATCH 2/2] ACPI: PCC: fix Tx done interface in handler


在 2022/9/21 23:43, Sudeep Holla 写道:
> On Tue, Sep 20, 2022 at 05:45:00PM +0800, Huisong Li wrote:
>> A error, "Client can't run the TX ticker", is printed even if PCC command
>> executed successfully. This root cause is that PCC handler calls
>> 'mbox_client_txdone()' which depands on the client can received 'ACK'
>> packet. But PCC handler detects whether the command is complete through
>> the Tx ACK interrupt. So this patch fix it.
>>
> Thanks for fixing this. Someone mentioned about the error and it was in
> my TODO list.
Great minds think alike😁
>
> I would prefer to reword the subject and commit message as below:
> "
> ACPI: PCC: Fix Tx acknowledge in the PCC address space handler
>
> Currently, mbox_client_txdone() is called from the PCC address space
> handler and that expects the user the Tx state machine to be controlled
> by the client which is not the case and the below warning is thrown:
>
>    | PCCT: Client can't run the TX ticker
>
> Let the controller run the state machine and the end of Tx can be
> acknowledge by calling mbox_chan_txdone() instead.
> "
Thank you for your suggestion. I will fix it in V2.
> With that:
>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
>