linux-kernel - Re: [PATCH v1 2/2] hwrng: npcm: Add NPCM8XX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21cc4e52-d0d9-8f07-fa74-ea62bb01432a@linaro.org>
Date:   Thu, 22 Sep 2022 17:08:34 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Tomer Maimon <tmaimon77@...il.com>, avifishman70@...il.com,
        tali.perry1@...il.com, joel@....id.au, venture@...gle.com,
        yuenn@...gle.com, benjaminfair@...gle.com, olivia@...enic.com,
        herbert@...dor.apana.org.au, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     openbmc@...ts.ozlabs.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v1 2/2] hwrng: npcm: Add NPCM8XX support

On 22/09/2022 16:22, Tomer Maimon wrote:
>  static int npcm_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
> @@ -102,6 +103,11 @@ static int npcm_rng_probe(struct platform_device *pdev)
>  	pm_runtime_use_autosuspend(&pdev->dev);
>  	pm_runtime_enable(&pdev->dev);
>  
> +	if (of_device_is_compatible(pdev->dev.of_node, "nuvoton,npcm750-rng"))
> +		priv->clkp = NPCM_RNG_CLK_SET_25MHZ;
> +	if (of_device_is_compatible(pdev->dev.of_node, "nuvoton,npcm845-rng"))
> +		priv->clkp = NPCM_RNG_CLK_SET_62_5MHZ;

No, don't sprinkle compatibles here and there. Driver data is for this.



Best regards,
Krzysztof