linux-kernel - Re: [PATCH v6] dmaengine: mxs: use platform_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YyvJ/hwu17gC9E/z@matsya>
Date:   Thu, 22 Sep 2022 08:05:42 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc:     linux-kernel@...r.kernel.org,
        Michael Trimarchi <michael@...rulasolutions.com>,
        linux-amarula@...rulasolutions.com,
        Robin Murphy <robin.murphy@....com>,
        Marco Felsch <m.felsch@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>, stable@...r.kernel.org,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>, dmaengine@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6] dmaengine: mxs: use platform_driver_register

On 21-09-22, 19:05, Dario Binacchi wrote:
> Driver registration fails on SOC imx8mn as its supplier, the clock
> control module, is probed later than subsys initcall level. This driver
> uses platform_driver_probe which is not compatible with deferred probing
> and won't be probed again later if probe function fails due to clock not
> being available at that time.
> 
> This patch replaces the use of platform_driver_probe with
> platform_driver_register which will allow probing the driver later again
> when the clock control module will be available.
> 
> The __init annotation has been dropped because it is not compatible with
> deferred probing. The code is not executed once and its memory cannot be
> freed.

Applied, thanks

-- 
~Vinod