linux-kernel - Re: [PATCH v4 25/25] tracing/rseq: Add mm_vcpu_id field to rseq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202209222301.8AZY1n7J-lkp@intel.com>
Date:   Thu, 22 Sep 2022 23:14:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Boqun Feng <boqun.feng@...il.com>,
        "H . Peter Anvin" <hpa@...or.com>, Paul Turner <pjt@...gle.com>,
        linux-api@...r.kernel.org, Christian Brauner <brauner@...nel.org>,
        Florian Weimer <fw@...eb.enyo.de>, David.Laight@...lab.com,
        carlos@...hat.com, Peter Oskolkov <posk@...k.io>,
        Alexander Mikhalitsyn <alexander@...alicyn.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH v4 25/25] tracing/rseq: Add mm_vcpu_id field to
 rseq_update

Hi Mathieu,

I love your patch! Yet something to improve:

[auto build test ERROR on rostedt-trace/for-next]
[cannot apply to shuah-kselftest/next tip/sched/core kees/for-next/execve linus/master v6.0-rc6 next-20220921]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mathieu-Desnoyers/RSEQ-node-id-and-virtual-cpu-id-extensions/20220922-191315
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: i386-randconfig-a001
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/1e36316a4b14e773e904e677149f9f757057fd90
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mathieu-Desnoyers/RSEQ-node-id-and-virtual-cpu-id-extensions/20220922-191315
        git checkout 1e36316a4b14e773e904e677149f9f757057fd90
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:102,
                    from include/trace/events/rseq.h:62,
                    from kernel/rseq.c:19:
   include/trace/events/rseq.h: In function 'trace_event_raw_event_rseq_update':
>> include/trace/events/rseq.h:26:40: error: 'struct task_struct' has no member named 'mm_vcpu'
      26 |                 __entry->mm_vcpu_id = t->mm_vcpu;
         |                                        ^~
   include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
     402 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
      44 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/events/rseq.h:11:1: note: in expansion of macro 'TRACE_EVENT'
      11 | TRACE_EVENT(rseq_update,
         | ^~~~~~~~~~~
   include/trace/events/rseq.h:23:9: note: in expansion of macro 'TP_fast_assign'
      23 |         TP_fast_assign(
         |         ^~~~~~~~~~~~~~
   In file included from include/trace/define_trace.h:103,
                    from include/trace/events/rseq.h:62,
                    from kernel/rseq.c:19:
   include/trace/events/rseq.h: In function 'perf_trace_rseq_update':
>> include/trace/events/rseq.h:26:40: error: 'struct task_struct' has no member named 'mm_vcpu'
      26 |                 __entry->mm_vcpu_id = t->mm_vcpu;
         |                                        ^~
   include/trace/perf.h:89:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
      89 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
      44 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/events/rseq.h:11:1: note: in expansion of macro 'TRACE_EVENT'
      11 | TRACE_EVENT(rseq_update,
         | ^~~~~~~~~~~
   include/trace/events/rseq.h:23:9: note: in expansion of macro 'TP_fast_assign'
      23 |         TP_fast_assign(
         |         ^~~~~~~~~~~~~~


vim +26 include/trace/events/rseq.h

    12	
    13		TP_PROTO(struct task_struct *t),
    14	
    15		TP_ARGS(t),
    16	
    17		TP_STRUCT__entry(
    18			__field(s32, cpu_id)
    19			__field(s32, node_id)
    20			__field(s32, mm_vcpu_id)
    21		),
    22	
    23		TP_fast_assign(
    24			__entry->cpu_id = raw_smp_processor_id();
    25			__entry->node_id = cpu_to_node(raw_smp_processor_id());
  > 26			__entry->mm_vcpu_id = t->mm_vcpu;
    27		),
    28	
    29		TP_printk("cpu_id=%d node_id=%d mm_vcpu_id=%d", __entry->cpu_id,
    30			  __entry->node_id, __entry->mm_vcpu_id)
    31	);
    32	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (150318 bytes)