linux-kernel - Re: [PATCH 1/2] pinctrl: rockchip: add pinmux_ops.gpio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2022 20:14:48 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Quentin Schulz <foss+kernel@...il.net>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl, jay.xu@...k-chips.com,
        linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        foss+kernel@...il.net,
        Quentin Schulz <quentin.schulz@...obroma-systems.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: rockchip: add pinmux_ops.gpio_set_direction callback

Am Freitag, 23. September 2022, 16:51:40 CEST schrieb Quentin Schulz:
> From: Quentin Schulz <quentin.schulz@...obroma-systems.com>
> 
> Before the split of gpio and pinctrl sections in their own driver,
> rockchip_set_mux was called in pinmux_ops.gpio_set_direction for
> configuring a pin in its GPIO function.
> 
> This is essential for cases where pinctrl is "bypassed" by gpio
> consumers otherwise the GPIO function is not configured for the pin and
> it does not work. Such was the case for the sysfs/libgpiod userspace
> GPIO handling.
> 
> Let's re-implement the pinmux_ops.gpio_set_direction callback so that
> the gpio subsystem can request from the pinctrl driver to put the pin in
> its GPIO function.
> 
> Fixes: 9ce9a02039de ("pinctrl/rockchip: drop the gpio related codes")
> Cc: stable@...r.kernel.org
> Signed-off-by: Quentin Schulz <quentin.schulz@...obroma-systems.com>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>