linux-kernel - Re: [PATCH] PCI: fu740: do not use clock name when requesting clock

Open Source and information security mailing list archives

Message-ID: <20220923211439.GA1418979@bhelgaas>
Date:   Fri, 23 Sep 2022 16:14:39 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Icenowy Zheng <uwu@...nowy.me>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Greentime Hu <greentime.hu@...ive.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] PCI: fu740: do not use clock name when requesting clock

On Wed, Sep 07, 2022 at 01:40:20PM +0800, Icenowy Zheng wrote:
> The DT binding of FU740 PCIe does not enforce a clock-names property,
> and there exist some device tree that has a clock name that does not
> stick to the one used by Linux DT (e.g. the one shipped with current
> U-Boot mainline).
> 
> Drop the name in the clock request, instead just pass NULL (because
> this device should have only a single clock).

If you rework this for any reason, please capitalize the subject line
to match the convention:

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/pci/controller/dwc/pcie-fu740.c

> Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> ---
>  drivers/pci/controller/dwc/pcie-fu740.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
> index 0c90583c078b..edb218a37a4f 100644
> --- a/drivers/pci/controller/dwc/pcie-fu740.c
> +++ b/drivers/pci/controller/dwc/pcie-fu740.c
> @@ -315,7 +315,7 @@ static int fu740_pcie_probe(struct platform_device *pdev)
>  		return dev_err_probe(dev, PTR_ERR(afp->pwren), "unable to get pwren-gpios\n");
>  
>  	/* Fetch clocks */
> -	afp->pcie_aux = devm_clk_get(dev, "pcie_aux");
> +	afp->pcie_aux = devm_clk_get(dev, NULL);
>  	if (IS_ERR(afp->pcie_aux))
>  		return dev_err_probe(dev, PTR_ERR(afp->pcie_aux),
>  					     "pcie_aux clock source missing or invalid\n");
> -- 
> 2.37.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives