linux-kernel - Re: [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yy0+N13mJlGZE9E4@google.com>
Date:   Fri, 23 Sep 2022 13:03:51 +0800
From:   Tzung-Bi Shih <tzungbi@...nel.org>
To:     Trevor Wu <trevor.wu@...iatek.com>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, tiwai@...e.com, lgirdwood@...il.com,
        linux-mediatek@...ts.infradead.org, matthias.bgg@...il.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ASoC: mediatek: mt8195-mt6359: Use snd_soc_pm_ops
 instead of custom ops

On Fri, Sep 23, 2022 at 12:39:54PM +0800, Trevor Wu wrote:
> On Thu, 2022-09-22 at 16:10 +0200, AngeloGioacchino Del Regno wrote:
> > Il 22/09/22 15:30, Mark Brown ha scritto:
> > > On Thu, Sep 22, 2022 at 07:26:21PM +0800, Tzung-Bi Shih wrote:
> > > 
> > > > snd_soc_pm_ops[1] sets some more fields.  I'm not quite sure
> > > > whether
> > > > it would introduce any side effect or not.  Perhaps Trevor could
> > > > provide some suggestions.
> > > 
> > > If it does it should be to fix isues rather than introduce new
> > > problems - I suspect the other operations just don't work
> > > currently.
> > 
> >  From my upstream tests, this didn't introduce any issues, that's why
> > I've
> > sent this patch.
> > 
> > In any case, let's check with Trevor, just as to be extremely sure,
> > but please
> > use an upstream kernel for eventual tests, as there are quite a bit
> > of changes
> > between 5.10 and current upstream.
> > 
> > Cheers,
> > Angelo
> 
> I think it's not a big risk if Angelo already did the test and
> snd_soc_pm_ops is also used in MT8186.
> I can help do more tests on 5.10 when the patch is back to chromium in
> the future.
> MTK also have a plan to support complete suspend/resume functionality
> in MT8195. If Tzung-bi has concerns about the patch, I can help submit
> the patch at the time.

I have no further concern as long as you guys are also aware of the change.