linux-kernel - Re: [PATCH v2] mmc: wmt-sdmmc: Fix an error handling path in wmt_mci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yy134J0QUi1Z7BcZ@kadam>
Date:   Fri, 23 Sep 2022 12:09:52 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     ulf.hansson@...aro.org, cjb@...top.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH v2] mmc: wmt-sdmmc: Fix an error handling path in
 wmt_mci_probe()

On Thu, Sep 22, 2022 at 09:06:40PM +0200, Christophe JAILLET wrote:
> A dma_free_coherent() call is missing in the error handling path of the
> probe, as already done in the remove function.
> 
> Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Changes since v1:
>   * Add and use the (ugly named) 'fail5_and_a_half' label   [Dan Carpenter <dan.carpenter@...cle.com>]
> 

LOL.  This really made me laugh.

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter