linux-kernel - Re: linux-next: build failure after merge of the mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220923110144.GA1413812@ik1-406-35019.vs.sakura.ne.jp>
Date:   Fri, 23 Sep 2022 20:01:44 +0900
From:   Naoya Horiguchi <naoya.horiguchi@...ux.dev>
To:     Michael Walle <michael@...le.cc>
Cc:     sfr@...b.auug.org.au, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
        naoya.horiguchi@....com
Subject: Re: linux-next: build failure after merge of the mm tree

On Fri, Sep 23, 2022 at 11:50:13AM +0200, Michael Walle wrote:
> Hi,
> 
> > After merging the mm tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > drivers/base/memory.c: In function 'memory_block_online':
> > drivers/base/memory.c:186:34: error: 'struct memory_block' has no member na=
> > med 'nr_hwpoison'
> >   186 |         if (atomic_long_read(&mem->nr_hwpoison))
> >       |                                  ^~
> > drivers/base/memory.c: In function 'remove_memory_block_devices':
> > drivers/base/memory.c:870:61: error: 'struct memory_block' has no member na=
> > med 'nr_hwpoison'
> >   870 |                 clear_hwpoisoned_pages(atomic_long_read(&mem->nr_hw=
> > poison));
> >       |                                                             ^~
> > 
> > Caused by commit
> > 
> >   69b496f03bb4 ("mm/hwpoison: introduce per-memory_block hwpoison counter")
> > 
> > This build has CONFIG_MEMORY_FAILURE not set.

Sorry for inconvenience, I submitted a possible fix hours ago,
https://lore.kernel.org/linux-mm/20220923081827.GA1357512@ik1-406-35019.vs.sakura.ne.jp/T/#t
I think the above build error should be fixed by this.

(the updated patch is here https://lore.kernel.org/linux-mm/20220923082613.GB1357512@ik1-406-35019.vs.sakura.ne.jp/T/#u)

But ...

> 
> There also seems be more missing stubs. I'm getting:
> 
> aarch64-linux-gnu-ld: mm/memory-failure.o: in function `unpoison_memory':
> memory-failure.c:(.text+0x1c38): undefined reference to `memblk_nr_poison_sub'
> aarch64-linux-gnu-ld: mm/memory-failure.o: in function `num_poisoned_pages_inc':
> memory-failure.c:(.text+0x2c8c): undefined reference to `memblk_nr_poison_inc'
> aarch64-linux-gnu-ld: memory-failure.c:(.text+0x2cbc): undefined reference to `memblk_nr_poison_inc'
> 
> On a board where CONFIG_MEMORY_HOTPLUG is not set, but
> CONFIG_MEMORY_FAILURE is. So either there are stubs missing or
> MEMORY_FAILURE should depend MEMORY_HOTPLUG (?!).

Yes, the new field ->nr_hwpoison is meaningful only when both settings are
enabled, so I need/will update #ifdef condition to check MEMORY_HOTPLUG.
In x86, CONFIG_MEMORY_HOTPLUG=n and CONFIG_MEMORY_FAILURE=y does not show
this error.  So this error might be caused by arch dependency.
Anyway I'll update the patch again soon.
Thank you for the report.

- Naoya Horiguchi