linux-kernel - Re: [PATCH v5 6/6] iommu: Propagate return value in ->attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5e92bac499230a11868521771eaff6fcbc684d5.camel@mediatek.com>
Date:   Fri, 23 Sep 2022 09:09:38 +0800
From:   Yong Wu <yong.wu@...iatek.com>
To:     Nicolin Chen <nicolinc@...dia.com>, <joro@...tes.org>,
        <will@...nel.org>, <robin.murphy@....com>,
        <matthias.bgg@...il.com>, <jean-philippe@...aro.org>
CC:     <jgg@...dia.com>, <kevin.tian@...el.com>, <iommu@...ts.linux.dev>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v5 6/6] iommu: Propagate return value in ->attach_dev
 callback functions

On Thu, 2022-09-22 at 01:54 -0700, Nicolin Chen wrote:
> The mtk_iommu and virtio drivers have places in the ->attach_dev
> callback
> functions that return hardcode errnos instead of the returned values,
> but
> callers of these ->attach_dv callback functions may care. Propagate
> them
> directly without the extra conversions.
> 
> Reviewed-by: Kevin Tian <kevin.tian@...el.com>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@...aro.org>
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  drivers/iommu/mtk_iommu.c    | 2 +-
>  drivers/iommu/virtio-iommu.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Yong Wu <yong.wu@...iatek.com> #For mtk_iommu.c

Thanks.