linux-kernel - Re: Build regressions/improvements in v6.0-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87r102z4rq.fsf@mpe.ellerman.id.au>
Date:   Fri, 23 Sep 2022 21:52:57 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Helge Deller <deller@....de>, Randy Dunlap <rdunlap@...radead.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-kernel@...r.kernel.org
Cc:     linux-parisc@...r.kernel.org
Subject: Re: Build regressions/improvements in v6.0-rc5

Helge Deller <deller@....de> writes:
> On 9/20/22 23:07, Helge Deller wrote:
>> On 9/20/22 22:29, Randy Dunlap wrote:
>>>
>>>
>>> On 9/20/22 13:23, Helge Deller wrote:
>>>> On 9/12/22 11:22, Geert Uytterhoeven wrote:
>>>>> On Mon, 12 Sep 2022, Geert Uytterhoeven wrote:
>>>>>> JFYI, when comparing v6.0-rc5[1] to v6.0-rc4[3], the summaries are:
>>>>>>   - build errors: +16/-1
>>>>>
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: .cfi_endproc without corresponding .cfi_startproc:  => 32
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: bad or irreducible absolute expression:  => 16
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: junk at end of line, first unrecognized character is `:':  => 16
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: no such instruction: `be 0x100(%sr2,%r0)':  => 29
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: no such instruction: `ldi 0,%r20':  => 30
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: no such instruction: `ldw 0(%sp),%r31':  => 26
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: no such instruction: `ble 0x100(%sr2,%r0)':  => 46, 51
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: no such instruction: `ldi 0,%r25':  => 44
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: no such instruction: `ldi 1,%r25':  => 49
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: no such instruction: `ldi 173,%r20':  => 45, 50
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.callinfo':  => 40
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.entry':  => 41
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.exit':  => 54
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.proc':  => 39
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.procend':  => 55
>>>>>     + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.stringz':  => 76
>>>>>
>>>>> parisc-gcc8/generic-32bit_defconfig
>>>>>
>>>>>> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/80e78fcce86de0288793a0ef0f6acf37656ee4cf/ (all 135 configs)
>>>>>> [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/7e18e42e4b280c85b76967a9106a13ca61c16179/ (all 135 configs)
>>>>
>>>> I see those errors on the kiss website, but I'm unable to reproduce them.
>>>> Downloaded that .config, used same compiler (from https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.5.0/)....
>>>> Not sure how to get this fixed.
>>>> If someone has an idea or can reproduce, please let me know.
>>>
>>> Hi,
>>> I can reproduce it using the (x86_64 hosted) crosstool gcc-12.1.0 from kernel.org that Arnd builds/provides.
>>> https://mirrors.edge.kernel.org/pub/tools/crosstool/
>>
>> Ah....
>> Building with "make  ARCH=parisc  CROSS_COMPILE=/some/path/nolibc/hppa-linux/bin/hppa-linux-"
>> uses this CROSS_COMPILE prefix for compiling the .c files, but not for the .S files.
>> So, you will end up with the default hppa-linux-gcc installed on the system, not the one provided
>> by CROSS_COMPILE.
>
> Ok, it seems CROSS_COMPILE doesn't work as one would expect (and as it did in the past).
> I'm not sure if this can be fixed.
>
> Since kernel v5.18 the parisc kernel comes with a 32-bit and a 64-bit vDSO.
> On parisc we have two compilers:
> - hppa-linux-gnu-gcc for 32-bit, and
> - hppa64-linux-gnu-gcc for 64-bit code.
> There is no -m64 flag like on x86 which can be used to just use one compiler for both targets.
> If you provide a CROSS_COMPILE command, you can only provide either a 32- or 64-bit compiler,
> so e.g. you won't be able to build the 64-bit kernel and a 32-bit vDSO with the same compiler.
>
> Instead of using CROSS_COMPILE, please just install your compiler(s) and make sure that
> the compiler(s) can be found via the PATH environment variable.
> In arch/parisc/Makefile (line 42ff) various variants like hppa-linux-gnu-gcc or
> hppa1.1-unknown-linux-gnu-gcc will be searched.
>
> So, instead of
>   make ARCH=parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/hppa-linux/bin/hppa-linux-
> please use for 32-bit:
>   PATH=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/hppa-linux/bin/:$PATH     make ARCH=parisc
> or for 64-bit:
>   PATH=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/hppa64-linux/bin/:$PATH   make ARCH=parisc64

I actually did that change a while back, but hadn't pushed it to one of
the builders -_-

I've done that now, so we shouldn't see this error in future.

Sorry for the noise.

cheers