linux-kernel - Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4dfbb55-c8ae-e98c-89c3-4bfb54311a30@amd.com>
Date:   Fri, 23 Sep 2022 15:25:33 +0200
From:   Michal Simek <michal.simek@....com>
To:     Felipe Balbi <felipe@...bi.sh>, Piyush Mehta <piyush.mehta@....com>
CC:     <gregkh@...uxfoundation.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <linux-usb@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <siva.durga.prasad.paladugu@....com>,
        Manish Narani <manish.narani@...inx.com>
Subject: Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include
 hibernation interrupt

Hi Felipe,

On 9/23/22 14:43, Felipe Balbi wrote:
> 
> Hi,
> 
> Piyush Mehta <piyush.mehta@....com> writes:
>> From: Manish Narani <manish.narani@...inx.com>
>>
>> The hibernation feature enabled for Xilinx ZynqMP SoC in DWC3 IP.
>> Added the below interrupt-names in the binding schema for the same.
>>
>> dwc_usb3: dwc3 core interrupt-names
>> otg: otg interrupt-names
>> hiber: hibernation interrupt-names
>>
>> Signed-off-by: Manish Narani <manish.narani@...inx.com>
>> Signed-off-by: Piyush Mehta <piyush.mehta@....com>
>> ---
>>   Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> index 1779d08ba1c0..618fa7bd32be 100644
>> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> @@ -53,6 +53,8 @@ properties:
>>         - const: dwc_usb3
>>         - items:
>>             enum: [host, peripheral, otg]
>> +      - items:
>> +          enum: [dwc_usb3, otg, hiber]
> 
> I would spell it out; i.e. `hibernation' instead of `hiber'.

that wouldn't be an issue. What about that wake-up line?

Thanks,
Michal