linux-kernel - Re: [PATCH v2 01/13] trinity: Add base driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220924000932.689c44f37abecb153175ed8b@samsung.com>
Date:   Sat, 24 Sep 2022 00:09:32 +0900
From:   Jiho Chu <jiho.chu@...sung.com>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        ogabbay@...nel.org,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        "Mark Brown" <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        yelini.jeong@...sung.com, myungjoo.ham@...sung.com
Subject: Re: [PATCH v2 01/13] trinity: Add base driver

On Thu, 22 Sep 2022 15:56:51 +0200
"Arnd Bergmann" <arnd@...db.de> wrote:

> On Sat, Sep 17, 2022, at 4:49 PM, Jiho Chu wrote:
> > On Sat, 17 Sep 2022 09:41:13 +0200
> > "Arnd Bergmann" <arnd@...db.de> wrote:
> >> 
> >> If you have the need to manage multiple devices here, maybe use
> >> a dynamic major number and have the chardev code allocate the
> >> minor numbers, instead of using multiple misc devices and
> >> doing that yourself.
> >> 
> >
> > I'm little confusing. It means that managing own char devices is proper,
> > not using misc device? But, it's still under misc dir.
> 
> There is no strict connection between miscdevices and drivers/misc.
> 
> The former is for drivers that tend to have only one instance
> in a system, while the latter is for drivers that do not have
> a separate subsystem.
> 
>      Arnd
> 

Thanks for the clarification. Allocating a dynamic major could be better
for trinity, which could have multiple instances.
I'll rewrite code for it in next revision.

Best regards,
Jiho chu