linux-kernel - Re: [PATCH] minmax: clamp more efficiently by avoiding extra comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yy3M5Urqiz8jnIYe@smile.fi.intel.com>
Date:   Fri, 23 Sep 2022 18:12:37 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] minmax: clamp more efficiently by avoiding extra
 comparison

On Fri, Sep 23, 2022 at 12:48:48PM +0200, Jason A. Donenfeld wrote:
> On Fri, Sep 23, 2022 at 12:40 PM Jason A. Donenfeld <Jason@...c4.com> wrote:

...

> both for the old code and for the new code, the result of lo>hi is
> total nonsense:

Exactly and my point is to add at least compile-time check for constants.

-- 
With Best Regards,
Andy Shevchenko