linux-kernel - Re: [PATCH RESEND v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex) accelerator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C9DB484C-4527-4E0C-9FE4-6CF7C6BA579C@linux.alibaba.com>
Date:   Fri, 23 Sep 2022 09:53:50 +0800
From:   guanjun <guanjun@...ux.alibaba.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     "Elliott, Robert (Servers)" <elliott@....com>,
        "zelin.deng@...ux.alibaba.com" <zelin.deng@...ux.alibaba.com>,
        xuchun.shang@...ux.alibaba.com,
        "artie.ding@...ux.alibaba.com" <artie.ding@...ux.alibaba.com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography
 Complex) accelerator driver



> 2022年9月16日 下午5:35，Herbert Xu <herbert@...dor.apana.org.au> 写道：
> 
> On Tue, Sep 06, 2022 at 11:35:45AM +0800, 'Guanjun' wrote:
> .
>> +static const struct file_operations ycc_fops = {
>> +	.open = ycc_cdev_open,
>> +	.release = ycc_cdev_release,
>> +	.unlocked_ioctl = ycc_cdev_ioctl,
>> +};
> 
> What is this device for? It doesn't seem to do anything so why
> not jsut drop it?
> 
> Thanks,
> -- 
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Hi Herbert,
Do you have any other comments? If not, I will prepare for the next version :)

Thanks,

Regards,
Guanjun