linux-kernel - Re: [PATCH v4 i2c-master] i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2022 18:24:34 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Tharunkumar.Pasumarthi@...rochip.com
Cc:     UNGLinuxDriver@...rochip.com, krzk@...nel.org, arnd@...db.de,
        andriy.shevchenko@...ux.intel.com, robh@...nel.org,
        semen.protsenko@...aro.org, sven@...npeter.dev,
        jarkko.nikula@...ux.intel.com, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org, jsd@...ihalf.com, olof@...om.net,
        rafal@...ecki.pl
Subject: Re: [PATCH v4 i2c-master] i2c: microchip: pci1xxxx: Add driver for
 I2C host controller in multifunction endpoint of pci1xxxx switch


> > I need to make sure: do you intentionally want autoprobing for SPD? I
> > ask because it could be needed but it costs boottime when not needed.
> > And changing the class once exposed is troublesome.
> 
> Autoprobing is not required. I can modify code. 
> 
> All these comments need to be addressed now or can be fixed later after the
> patch is applied?

The issue above (autoprobing) should really not be fixed incrementally.
The other two issues could be, but if you need to resend anyhow, just
tackle them as well, please.

Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)