linux-kernel - Re: [PATCH -next] hwrng: Remove duplicate include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yy6yNaTVnwvHaN8U@gondor.apana.org.au>
Date:   Sat, 24 Sep 2022 15:31:01 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     williamsukatube@....com
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        williamsukatube@....com
Subject: Re: [PATCH -next] hwrng: Remove duplicate include

williamsukatube@....com wrote:
> From: William Dean <williamsukatube@....com>
> 
> In file: drivers/char/hw_random/core.c,
> '#include <linux/random.h>' has included at line: 18,
> now it is duplicated include at line: 24, so delete duplicated include.
> 
> Signed-off-by: William Dean <williamsukatube@....com>
> ---
> drivers/char/hw_random/core.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
> index 16f227b995e8..56d171cd2fc6 100644
> --- a/drivers/char/hw_random/core.c
> +++ b/drivers/char/hw_random/core.c
> @@ -21,7 +21,6 @@
> #include <linux/sched/signal.h>
> #include <linux/miscdevice.h>
> #include <linux/module.h>
> -#include <linux/random.h>
> #include <linux/sched.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>

This is supposed to be sorted so please remove the other inclusion
instead.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt