linux-kernel - Re: [PATCH V4 3/3] arch: crash: Remove duplicate declaration in smp.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJF2gTQqWFfcJsAn_UPaXVdC6HQecnLyFPBOrnpxrJfWJMsOeQ@mail.gmail.com>
Date:   Sat, 24 Sep 2022 18:56:39 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     xianting.tian@...ux.alibaba.com, palmer@...belt.com,
        palmer@...osinc.com, liaochang1@...wei.com, jszhang@...nel.org,
        arnd@...db.de, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        x86@...nel.org, linux-arm-kernel@...ts.infradead.org,
        Guo Ren <guoren@...ux.alibaba.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH V4 3/3] arch: crash: Remove duplicate declaration in smp.h

On Fri, Sep 23, 2022 at 7:00 PM Heiko Stuebner <heiko@...ech.de> wrote:
>
> Am Mittwoch, 21. September 2022, 05:31:34 CEST schrieb guoren@...nel.org:
> > From: Guo Ren <guoren@...ux.alibaba.com>
> >
> > Remove crash_smp_send_stop declarations in arm64, x86 asm/smp.h which
> > has been done in include/linux/smp.h.
>
> nit: the commit message could reference the commit that brought in the
> generic declarations, which was
>         6f1f942cd5fb ("smp: kernel/panic.c - silence warnings")
Good advice, thx.

>
> other than that
> Reviewed-by: Heiko Stuebner <heiko@...ech.de>
>
>
> > Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> > Signed-off-by: Guo Ren <guoren@...nel.org>
> > Acked-by: Catalin Marinas <catalin.marinas@....com>
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > ---
> >  arch/arm64/include/asm/smp.h | 1 -
> >  arch/x86/include/asm/crash.h | 1 -
> >  2 files changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
> > index fc55f5a57a06..a108ac93fd8f 100644
> > --- a/arch/arm64/include/asm/smp.h
> > +++ b/arch/arm64/include/asm/smp.h
> > @@ -141,7 +141,6 @@ static inline void cpu_panic_kernel(void)
> >   */
> >  bool cpus_are_stuck_in_kernel(void);
> >
> > -extern void crash_smp_send_stop(void);
> >  extern bool smp_crash_stop_failed(void);
> >  extern void panic_smp_self_stop(void);
> >
> > diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h
> > index 8b6bd63530dc..6a9be4907c82 100644
> > --- a/arch/x86/include/asm/crash.h
> > +++ b/arch/x86/include/asm/crash.h
> > @@ -7,6 +7,5 @@ struct kimage;
> >  int crash_load_segments(struct kimage *image);
> >  int crash_setup_memmap_entries(struct kimage *image,
> >               struct boot_params *params);
> > -void crash_smp_send_stop(void);
> >
> >  #endif /* _ASM_X86_CRASH_H */
> >
>
>
>
>


-- 
Best Regards
 Guo Ren