linux-kernel - Re: [PATCH 5.10 25/39] Revert "serial: 8250: Fix reporting real baudrate value in c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzBxpId55dT2eU6C@sashalap>
Date:   Sun, 25 Sep 2022 11:20:04 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Pali Rohár <pali@...nel.org>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH 5.10 25/39] Revert "serial: 8250: Fix reporting real
 baudrate value in c_ospeed field"

On Wed, Sep 21, 2022 at 10:05:02PM +0200, Pavel Machek wrote:
>Hi!
>
>> From: Johan Hovold <johan@...nel.org>
>>
>> commit d02b006b29de14968ba4afa998bede0d55469e29 upstream.
>>
>> This reverts commit 32262e2e429cdb31f9e957e997d53458762931b7.
>>
>> The commit in question claims to determine the inverse of
>> serial8250_get_divisor() but failed to notice that some drivers override
>> the default implementation using a get_divisor() callback.
>
>I believe it would be better to remove bad commit and its revert,
>since it was not yet released.

No - this way we can track the story of the commit. If someone shows up
a year from now and asks why this certain patch isn't in -stable it's
much easier to answer that (and not to queue it up by mistake).

-- 
Thanks,
Sasha