linux-kernel - Re: [PATCH linux-next] watchdog: rti-wdt:using the pm_runtime_resume_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 25 Sep 2022 10:17:56 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     cgel.zte@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] watchdog: rti-wdt:using the
 pm_runtime_resume_and_get  to simplify the code

On Tue, Aug 02, 2022 at 07:46:43AM +0000, cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Using pm_runtime_resume_and_get() to instade of  pm_runtime_get_sync
> and pm_runtime_put_noidle.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/rti_wdt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
> index 053ef3bde12d..6e9253761fc1 100644
> --- a/drivers/watchdog/rti_wdt.c
> +++ b/drivers/watchdog/rti_wdt.c
> @@ -225,9 +225,8 @@ static int rti_wdt_probe(struct platform_device *pdev)
>  		wdt->freq = wdt->freq * 9 / 10;
>  
>  	pm_runtime_enable(dev);
> -	ret = pm_runtime_get_sync(dev);
> +	ret = pm_runtime_resume_and_get(dev);
>  	if (ret < 0) {
> -		pm_runtime_put_noidle(dev);
>  		pm_runtime_disable(&pdev->dev);
>  		return dev_err_probe(dev, ret, "runtime pm failed\n");
>  	}