linux-kernel - Re: [PATCH] staging: rtl8192e: Rename Tx_Retry_Count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59255558-06ed-d82f-3e72-f1ccf03ba96d@gmail.com>
Date:   Sun, 25 Sep 2022 21:26:35 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Dragan Cvetic <dragan.m.cvetic@...il.com>,
        gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Rename Tx_Retry_Count_Reg

On 9/25/22 00:51, Dragan Cvetic wrote:
> Rename: Current_Tx_Rate_Reg to CURRENT_TX_RATE_REG, Initial_Tx_Rate_Reg to
> INITIAL_TX_RATE_REG and Tx_Retry_Count_Reg to TX_RETRY_COUNT_REG to avoid
> CamelCase which is not accepted by checkpatch.pl.
> 
> Signed-off-by: Dragan Cvetic <dragan.m.cvetic@...il.com>
> ---
>   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 11 +++--------
>   drivers/staging/rtl8192e/rtl8192e/rtl_dm.h |  6 +++---
>   2 files changed, 6 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index 3ee52147960e..9fefa1a7ae75 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -2499,14 +2499,9 @@ static void _rtl92e_dm_check_txrateandretrycount(struct net_device *dev)
>   	struct r8192_priv *priv = rtllib_priv(dev);
>   	struct rtllib_device *ieee = priv->rtllib;
>   
> -	ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev,
> -						 Current_Tx_Rate_Reg);
> -
> -	ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev,
> -						 Initial_Tx_Rate_Reg);
> -
> -	ieee->softmac_stats.txretrycount = rtl92e_readl(dev,
> -						 Tx_Retry_Count_Reg);
> +	ieee->softmac_stats.CurrentShowTxate = rtl92e_readb(dev, CURRENT_TX_RATE_REG);
> +	ieee->softmac_stats.last_packet_rate = rtl92e_readb(dev, INITIAL_TX_RATE_REG);
> +	ieee->softmac_stats.txretrycount = rtl92e_readl(dev, TX_RETRY_COUNT_REG);
>   }
>   
>   static void _rtl92e_dm_send_rssi_to_fw(struct net_device *dev)
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
> index ea1b14bbcdcd..51e295d389a8 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h
> @@ -42,9 +42,9 @@
>   #define	 TX_POWER_ATHEROAP_THRESH_HIGH	   78
>   #define		TX_POWER_ATHEROAP_THRESH_LOW		72
>   
> -#define			Current_Tx_Rate_Reg	 0x1e0
> -#define			Initial_Tx_Rate_Reg	 0x1e1
> -#define			Tx_Retry_Count_Reg	 0x1ac
> +#define		CURRENT_TX_RATE_REG		0x1e0
> +#define		INITIAL_TX_RATE_REG		0x1e1
> +#define		TX_RETRY_COUNT_REG		0x1ac
>   #define		RegC38_TH				 20
>   
>   #define		DM_Type_ByDriver		1

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>