linux-kernel - Re: significant drop fio IOPS performance on v5.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89273C3B-010F-46A4-B5CD-86EBAF91C188@amazon.com>
Date:   Sun, 25 Sep 2022 09:26:33 +0000
From:   "Mohamed Abuelfotoh, Hazem" <abuehaze@...zon.com>
To:     "Lu, Davina" <davinalu@...zon.com>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Theodore Ts'o <tytso@....edu>
CC:     "Kiselev, Oleg" <okiselev@...zon.com>,
        "Liu, Frank" <franklmz@...zon.com>
Subject: Re: significant drop  fio IOPS performance on v5.10

This is continuation for the discussion I raised in https://lore.kernel.org/all/CACX6voDhGxiyAxaEu0OL+hHFDD9kigso-YVrWTk4jcbvYZKVew@mail.gmail.com/t/ so I am adding Theo to the thread.

Hazem

On 25/09/2022, 09:51, "Lu, Davina" <davinalu@...zon.com> wrote:

    + abuehaze@...zon.com

    -----Original Message-----
    From: Lu, Davina 
    Sent: Friday, September 23, 2022 10:55 AM
    To: linux-ext4@...r.kernel.org; linux-kernel@...r.kernel.org
    Cc: Kiselev, Oleg <okiselev@...zon.com>; Liu, Frank <franklmz@...zon.com>
    Subject: significant drop fio IOPS performance on v5.10

    Hello,

    I was profiling the 5.10 kernel and comparing it to 4.14.  On a system with 64 virtual CPUs and 256 GiB of RAM, I am observing a significant drop in IO performance. Using the following FIO with the script "sudo ftest_write.sh <dev_name>" in attachment, I saw FIO iops result drop from 22K to less than 1K. 
    The script simply does: mount a the EXT4 16GiB volume with max IOPS 64000K, mounting option is " -o noatime,nodiratime,data=ordered", then run fio with 2048 fio wring thread with 28800000 file size with { --name=16kb_rand_write_only_2048_jobs --directory=/rdsdbdata1 --rw=randwrite --ioengine=sync --buffered=1 --bs=16k --max-jobs=2048 --numjobs=2048 --runtime=60 --time_based --thread --filesize=28800000 --fsync=1 --group_reporting }.

    My analyzing is that the degradation is introduce by commit {244adf6426ee31a83f397b700d964cff12a247d3} and the issue is the contention on rsv_conversion_wq.  The simplest option is to increase the journal size, but that introduces more operational complexity.  Another option is to add the following change in attachment "allow more ext4-rsv-conversion workqueue.patch"

    From 27e1b0e14275a281b3529f6a60c7b23a81356751 Mon Sep 17 00:00:00 2001
    From: davinalu <davinalu@...zon.com>
    Date: Fri, 23 Sep 2022 00:43:53 +0000
    Subject: [PATCH] allow more ext4-rsv-conversion workqueue to speedup fio  writing
    ---
     fs/ext4/super.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/ext4/super.c b/fs/ext4/super.c index a0af833f7da7..6b34298cdc3b 100644
    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -4963,7 +4963,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
             * concurrency isn't really necessary.  Limit it to 1.
             */
            EXT4_SB(sb)->rsv_conversion_wq =
    -               alloc_workqueue("ext4-rsv-conversion", WQ_MEM_RECLAIM | WQ_UNBOUND, 1);
    +               alloc_workqueue("ext4-rsv-conversion", WQ_MEM_RECLAIM | 
    + WQ_UNBOUND | __WQ_ORDERED, 0);
            if (!EXT4_SB(sb)->rsv_conversion_wq) {
                    printk(KERN_ERR "EXT4-fs: failed to create workqueue\n");
                    ret = -ENOMEM;

    My thought is: If the max_active is 1, it means the "__WQ_ORDERED" combined with WQ_UNBOUND setting, based on alloc_workqueue(). So I added it .
    I am not sure should we need "__WQ_ORDERED" or not? without "__WQ_ORDERED" it looks also work at my testbed, but I added since not much fio TP difference on my testbed result with/out "__WQ_ORDERED".

    From My understanding and observation: with dioread_unlock and delay_alloc both enabled,  the  bio_endio() and ext4_writepages() will trigger this work queue to ext4_do_flush_completed_IO(). Looks like the work queue is an one-by-one updating: at EXT4 extend.c io_end->list_vec  list only have one io_end_vec each time. So if the BIO has high performance, and we have only one thread to do EXT4 flush will be an bottleneck here. The "ext4-rsv-conversion" this workqueue is mainly for update the EXT4_IO_END_UNWRITTEN extend block(only exist on dioread_unlock and delay_alloc options are set) and extend status  if I understand correctly here. Am  I correct?

    This works on my test system and passes xfstests, but  will this cause any corruption on ext4 extends blocks updates, not even sure about the journal transaction updates either?
    Can you tell me what I will break if this change is made?

    Thanks
    Davina