linux-kernel - Re: [PATCH -next] module: Remove unused macros module_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ddafe26-a5c3-c617-526e-f41dfb57b82f@csgroup.eu>
Date:   Mon, 26 Sep 2022 05:50:34 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Chen Zhongjin <chenzhongjin@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>
CC:     "mcgrof@...nel.org" <mcgrof@...nel.org>
Subject: Re: [PATCH -next] module: Remove unused macros module_addr_min/max



Le 24/09/2022 à 09:22, Chen Zhongjin a écrit :
> Unused macros reported by [-Wunused-macros].
> 
> These macros are introduced to record the bound address of modules.
> 
> '80b8bf436990 ("module: Always have struct mod_tree_root")'
> This commit has made struct mod_tree_root always exist, which means
> we can always referencing mod_tree derectly rather than using this
> macro.
> 
> So they are useless, remove them for code cleaning.

Yeah, it looks like this removal got lost during a rebase.
Should have been part of 55ce556dbf92 ("module: Remove module_addr_min 
and module_addr_max")

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> 
> Signed-off-by: Chen Zhongjin <chenzhongjin@...wei.com>
> ---
>   kernel/module/main.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index a4e4d84b6f4e..96dcc950da60 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -84,9 +84,6 @@ struct mod_tree_root mod_data_tree __cacheline_aligned = {
>   };
>   #endif
>   
> -#define module_addr_min mod_tree.addr_min
> -#define module_addr_max mod_tree.addr_max
> -
>   struct symsearch {
>   	const struct kernel_symbol *start, *stop;
>   	const s32 *crcs;