linux-kernel - Re: [PATCH -next] watchdog: Add __init/__exit annotations to module init/exit funcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d685b80-d0a1-c3ed-173e-e482f00d8e67@roeck-us.net>
Date:   Mon, 26 Sep 2022 06:35:50 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     ruanjinjie <ruanjinjie@...wei.com>, wim@...ux-watchdog.org,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] watchdog: Add __init/__exit annotations to module
 init/exit funcs

On 9/26/22 05:04, ruanjinjie wrote:
> Add missing __init/__exit annotations to module init/exit funcs
> 
> Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>

There are way too many patches lately which don't reflect the affected
driver in the subject line. I am not going to respond to those
anymore and ignore them.

Guenter

> ---
>   drivers/watchdog/cpu5wdt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/cpu5wdt.c b/drivers/watchdog/cpu5wdt.c
> index 688b112e712b..3e4534e8fa4b 100644
> --- a/drivers/watchdog/cpu5wdt.c
> +++ b/drivers/watchdog/cpu5wdt.c
> @@ -242,7 +242,7 @@ static int cpu5wdt_init(void)
>   	return err;
>   }
>   
> -static int cpu5wdt_init_module(void)
> +static int __init cpu5wdt_init_module(void)
>   {
>   	return cpu5wdt_init();
>   }
> @@ -261,7 +261,7 @@ static void cpu5wdt_exit(void)
>   
>   }
>   
> -static void cpu5wdt_exit_module(void)
> +static void __exit cpu5wdt_exit_module(void)
>   {
>   	cpu5wdt_exit();
>   }