linux-kernel - Re: [PATCH] usb: dwc3: st: Fix node's child name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <704b3687-d102-711a-0686-833ddc95b77f@kernel.org>
Date:   Mon, 26 Sep 2022 15:52:26 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     patrice.chotard@...s.st.com, Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Jerome Audu <jerome.audu@...com>
Subject: Re: [PATCH] usb: dwc3: st: Fix node's child name

On 26/09/2022 14:43, patrice.chotard@...s.st.com wrote:
> From: Patrice Chotard <patrice.chotard@...s.st.com>
> 
> Update node's child name from "dwc3" to "usb", this fixes
> the following issue:
> 
> [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
> 
> Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
> 
> Reported-by: Jerome Audu <jerome.audu@...com>
> Signed-off-by: Patrice Chotard <patrice.chotard@...s.st.com>
> ---
>  drivers/usb/dwc3/dwc3-st.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index 166b5bde45cb..6c14a79279f9 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>  	/* Manage SoftReset */
>  	reset_control_deassert(dwc3_data->rstc_rst);
>  
> -	child = of_get_child_by_name(node, "dwc3");
> +	child = of_get_child_by_name(node, "usb");

While this is a ok, the proper fix is not to rely on any other device
nodes or document it in the bindings.

Best regards,
Krzysztof