linux-kernel - Re: [PATCH] drm/panel-edp: Add INX N116BCA-EA2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2022 07:54:19 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Sean Hong <sean.hong@...nta.corp-partner.google.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/panel-edp: Add INX N116BCA-EA2

Hi,

On Mon, Sep 26, 2022 at 7:39 AM Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> On Mon, Sep 26, 2022 at 3:08 AM Sean Hong
> <sean.hong@...nta.corp-partner.google.com> wrote:
> >
> > Add support for the INX - N116BCA-EA2 (HW: C1) panel
> >
> > Signed-off-by: Sean Hong <sean.hong@...nta.corp-partner.google.com>
> > ---
> >  drivers/gpu/drm/panel/panel-edp.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> > index 060f4f98bc04..ba75fae7d376 100644
> > --- a/drivers/gpu/drm/panel/panel-edp.c
> > +++ b/drivers/gpu/drm/panel/panel-edp.c
> > @@ -1889,6 +1889,7 @@ static const struct edp_panel_entry edp_panels[] = {
> >         EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
> >
> >         EDP_PANEL_ENTRY('C', 'M', 'N', 0x114c, &innolux_n116bca_ea1.delay, "N116BCA-EA1"),
> > +       EDP_PANEL_ENTRY('C', 'M', 'N', 0x1154, &delay_200_500_p2e80, "N116BCA-EA2"),
> >         EDP_PANEL_ENTRY('C', 'M', 'N', 0x1247, &delay_200_500_e80_d50, "N120ACA-EA1"),
>
> This patch doesn't apply cleanly. You should be posting it against the
> top of drm-misc-next to make it easy to apply.
>
> In this case the merge conflict was trivial so I've fixed it and pushed it but:
> * Other folks applying patches won't do this.
> * If a patch is more complicated, I won't do this either.
>
> In any case, this is now in drm-misc-next as:
>
> c7bcc1056cff drm/panel-edp: Add INX N116BCA-EA2

Actually, though I've applied this change, while I was picking things
to the downstream ChromeOS tree I was reminded about a patch that
Chen-Yu landed recently:

https://patchwork.freedesktop.org/patch/msgid/20220908085454.1024167-1-wenst@chromium.org

I suspect that the two Innolux panels that you added recently need the
same treatment. Can you please post a patch for that? Said another
way: I think all of the Innolux panels that are using
"delay_200_500_p2e80" should switch to "delay_200_500_e80_d50"

Thanks!