linux-kernel - Re: [PATCH] perf arm-spe: augment the data source type with neoverse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzG+goZySC4K8S4Z@leoy-huanghe.lan>
Date:   Mon, 26 Sep 2022 23:00:31 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Ali Saidi <alisaidi@...zon.com>
Cc:     renyu.zj@...ux.alibaba.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, german.gomez@....com,
        james.clark@....com, john.garry@...wei.com, jolsa@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, mark.rutland@....com,
        mike.leach@...aro.org, mingo@...hat.com, namhyung@...nel.org,
        peterz@...radead.org, timothy.hayes@....com, will@...nel.org,
        xueshuai@...ux.alibaba.com, zhuo.song@...ux.alibaba.com
Subject: Re: [PATCH] perf arm-spe: augment the data source type with
 neoverse_spe list

On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > source information by MIDR. However, is_midr_in_range only compares the
> > first entry in neoverse_spe.
> > 
> > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > neoverse_spe array so that all neoverse cores synthesize event with data
> > source packet.
> > 
> > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > Signed-off-by: Jing Zhang <renyu.zj@...ux.alibaba.com>
> 
> Thanks for catching this, you're absolutely right.
> 
> Reviewed-by: Ali Saidi <alisaidi@...zon.com>

It's also good for me:
Reviewed-by: Leo Yan <leo.yan@...aro.org>