linux-kernel - Re: [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2022 17:00:50 +0200
From:   Luca Weiss <luca@...tu.xyz>
To:     linux-arm-msm@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types

On Montag, 26. September 2022 10:51:45 CEST Krzysztof Kozlowski wrote:
> On 25/09/2022 23:17, Luca Weiss wrote:
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> >      additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec
> >      binding not converted yet> 
> > +  "charger@[0-9a-f]+$":
> > +    type: object
> > +    oneOf:
> > +      - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> > +      - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> > +
> > +  "^dcdc@[0-9a-f]+$":
> > +    type: object
> 
> How about renaming this one to usb-vbus-regulator?

Sounds good to me. I was actually hoping somebody would suggest a better name.

Should I wait a bit to see if anybody else has a better suggestion or send a 
v2 now?

Regards
Luca

> 
> Best regards,
> Krzysztof