linux-kernel - Re: [PATCH] pcmcia: at91_cf: switch to using gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c694229c-a4cb-eff7-71cd-e6a5b3be9169@microchip.com>
Date:   Mon, 26 Sep 2022 17:26:47 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>
CC:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>
Subject: Re: [PATCH] pcmcia: at91_cf: switch to using gpiod API

On 25/09/2022 at 14:24, Linus Walleij wrote:
> On Sat, Sep 24, 2022 at 4:19 PM Dominik Brodowski
> <linux@...inikbrodowski.net> wrote:
> 
>> From: Dominik Brodowski <linux@...inikbrodowski.net>
>> Subject: [PATCH] pcmcia: remove AT91RM9200 Compact Flash driver
>>
>> As noted by Arnd Bergmann, "we used to have three drivers for the same
>> hardware (pcmcia, pata and ide), and only the pcmcia driver remained
>> in the tree after drivers/ide/ was removed and pata_at91 did not get
>> converted to DT". "There is no dts file in tree that actually declares
>> either of them, so chances are that nobody is actually using the CF
>> slot on at91 any more."[1]
>>
>> On this rationale, remove the AT91RM9200 Compact Flash driver, which
>> also assists in reaching "the goal of stopping exporting OF-specific
>> APIs of gpiolib".[2]
>>
>> [1] https://lore.kernel.org/lkml/68c63077-848b-45f5-8aca-ed995391f2b6@www.fastmail.com/
>> [2] https://lore.kernel.org/lkml/Yy6d7TjqzUwGQnQa@penguin/
>>
>> Signed-off-by: Dominik Brodowski <linux@...inikbrodowski.net>
> 
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> If someone actually has an AT91 board with this hardware and
> want to be able to use it by converting this driver to device tree,
> this is the time to step up.

Agreed with what was said. If people want reference code to make this 
driver revive, git history is there to help.

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Regards,
   Nicolas



-- 
Nicolas Ferre