linux-kernel - Re: [PATCH] tty: serial: atmel: Add COMMON_CLK dependency to SERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47b7352e-153d-22e0-6bb6-5a7b17b6a081@microchip.com>
Date:   Mon, 26 Sep 2022 17:37:07 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Sergiu Moga <sergiu.moga@...rochip.com>,
        <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
        <claudiu.beznea@...rochip.com>, <richard.genoud@...il.com>,
        <linux-serial@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] tty: serial: atmel: Add COMMON_CLK dependency to
 SERIAL_ATMEL

On 26/09/2022 at 16:32, Sergiu Moga wrote:
> Now that the driver makes use of `__clk_is_enabled()` in order to
> know whether a `clk_disable_unprepare()` is needed or not on the
> GCLK, a new dependency has been introduced: COMMON_CLK. If this
> `CONFIG_COMMON_CLK` is not enabled, whatever config may have this
> driver enabled without COMMON_CLK then an undefined reference to
> `__clk_is_enabled()` will be issued by the linker.
> 
> Thus, make sure that, unless `CONFIG_COMMON_CLK` is enabled, this
> driver is not compiled.
> 
> Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Sergiu Moga <sergiu.moga@...rochip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/tty/serial/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index a18dd525e42b..1aec3cf002f7 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -127,6 +127,7 @@ config SERIAL_SB1250_DUART_CONSOLE
>   
>   config SERIAL_ATMEL
>   	bool "AT91 on-chip serial port support"
> +	depends on COMMON_CLK
>   	depends on ARCH_AT91 || COMPILE_TEST
>   	select SERIAL_CORE
>   	select SERIAL_MCTRL_GPIO if GPIOLIB


-- 
Nicolas Ferre