linux-kernel - Re: [RFC PATCH] x86/syscalls: allow tracing of __do_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220926124651.5d35dd5f@gandalf.local.home>
Date:   Mon, 26 Sep 2022 12:46:51 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Nadav Amit <nadav.amit@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        x86@...nel.org, Dave Hansen <dave.hansen@...ux.intel.com>,
        Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...hat.com>,
        Nadav Amit <namit@...are.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [RFC PATCH] x86/syscalls: allow tracing of __do_sys_[syscall]
 functions

On Tue, 13 Sep 2022 06:52:13 -0700
Nadav Amit <nadav.amit@...il.com> wrote:

> +++ b/include/linux/compiler_types.h
> @@ -152,8 +152,12 @@ struct ftrace_likely_data {
>   * externally visible function. This makes extern inline behave as per gnu89
>   * semantics rather than c99. This prevents multiple symbol definition errors
>   * of extern inline functions at link time.
> - * A lot of inline functions can cause havoc with function tracing.
> + *
> + * A lot of inline functions can cause havoc with function tracing. If the
> + * function is known to be safe for tracing, inline_trace can be used. Otherwise
> + * inline would prevent tracing.

Perhaps add:

 * Don't complain if this function is not available to trace!

  ;-)

-- Steve

>   */
> +#define inline_trace __inline __gnu_inline __inline_maybe_unused
>  #define inline inline __gnu_inline __inline_maybe_unused notrace
>