[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YzHcX2VLh+0n2mAP@nvidia.com>
Date: Mon, 26 Sep 2022 14:07:43 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Deming Wang <wangdeming@...pur.com>
Cc: pbonzini@...hat.com, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio: Use filp instead of fd
On Mon, Sep 26, 2022 at 02:54:07AM -0400, Deming Wang wrote:
> The function of kvm_vfio_group_set_spapr_tce and kvm_vfio_group_del
> use fd indirectly.But,it only be used for fd.file. So,we can directly
> use the struct of file instead.
>
> Signed-off-by: Deming Wang <wangdeming@...pur.com>
> ---
> virt/kvm/vfio.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
I thought about changing this too when I was looking at
this. fdget/fdput includes a tiny micro-optimization that is legal
here, however I doubt anyone cares about performance on this path.
Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
Jason
Powered by blists - more mailing lists