linux-kernel - Re: [PATCH 2/7] net: fix cpu_max_bits_warn() usage in netif_attrmask_next{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220926103437.322f3c6c@kernel.org>
Date:   Mon, 26 Sep 2022 10:34:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yury Norov <yury.norov@...il.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH 2/7] net: fix cpu_max_bits_warn() usage in
 netif_attrmask_next{,_and}

On Mon, 19 Sep 2022 14:05:54 -0700 Yury Norov wrote:
> The functions require to be passed with a cpu index prior to one that is
> the first to start search, so the valid input range is [-1, nr_cpu_ids-1).
> However, the code checks against [-1, nr_cpu_ids).

Yup, the analysis looks correct:

Acked-by: Jakub Kicinski <kuba@...nel.org>