linux-kernel - Re: [PATCH 2/2] video: fbdev: gbefb: Remove unproper information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3571e46-40d2-9b96-848b-ea7ceb8646be@suse.de>
Date:   Mon, 26 Sep 2022 09:09:32 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Helge Deller <deller@....de>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>, broonie@...nel.org,
        maarten.lankhorst@...ux.intel.com, daniel.vetter@...ll.ch
Cc:     linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 2/2] video: fbdev: gbefb: Remove unproper information

Hi

Am 25.09.22 um 13:24 schrieb Helge Deller:
> On 9/2/22 04:56, Jiasheng Jiang wrote:
>> When drivers are working properly, they are quiet.
>> Therefore, the fb_info() should be removed.
> 
> NAK.
> This seems to be useful info about the detected card and it's only
> printed once.

Well, he has a point. Maybe this could become an fb_dbg() ?  (BTW, it's 
a bit unfortunate that there's an fb_info macro and an fb_info struct. :/)

Best regards
Thomas

> 
> Helge
> 
>> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
>> ---
>>   drivers/video/fbdev/gbefb.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
>> index 1582c718329c..7e39ab939691 100644
>> --- a/drivers/video/fbdev/gbefb.c
>> +++ b/drivers/video/fbdev/gbefb.c
>> @@ -1217,10 +1217,6 @@ static int gbefb_probe(struct platform_device 
>> *p_dev)
>>
>>       platform_set_drvdata(p_dev, info);
>>
>> -    fb_info(info, "%s rev %d @ 0x%08x using %dkB memory\n",
>> -        info->fix.id, gbe_revision, (unsigned)GBE_BASE,
>> -        gbe_mem_size >> 10);
>> -
>>       return 0;
>>
>>   out_gbe_unmap:
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)