linux-kernel - Re: [PATCH net V2] net: lan743x: Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External Timestamp (extts)")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220926130429.3ffd78b1@kernel.org>
Date:   Mon, 26 Sep 2022 13:04:29 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <bryan.whitehead@...rochip.com>,
        <richardcochran@...il.com>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <UNGLinuxDriver@...rochip.com>,
        <Ian.Saturley@...rochip.com>
Subject: Re: [PATCH net V2] net: lan743x: Fixes: 60942c397af6 ("Add support
 for PTP-IO Event Input External  Timestamp (extts)")

On Fri, 23 Sep 2022 15:11:34 +0530 Raju Lakkaraju wrote:
> Subject: [PATCH net V2] net: lan743x: Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External  Timestamp (extts)")
> 
> Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not
> support the PTP-IO Input event triggered timestamping mechanisms
> added
> 
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>

The fixes tag should go before your sign-off. So something like:

Subject: eth: lan743x: reject extts for non-pci11x1x devices

Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not
support the PTP-IO Input event triggered timestamping mechanisms
added [...]

Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External  Timestamp (extts)")
Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>


I'd be good to add to the commit message what the user-visible problem
will be. Crash or just silently accepting a config which won't work?