linux-kernel - Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2022 18:34:04 -0400
From:   Peter Geis <pgwipeout@...il.com>
To:     Peter Geis <pgwipeout@...il.com>, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC support" 
        <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to
 rk3568 PCIe v3 PHY

On Mon, Sep 26, 2022 at 4:36 PM Aurelien Jarno <aurelien@...el32.net> wrote:
>
> On 2022-09-26 14:58, Peter Geis wrote:
> > On Mon, Sep 26, 2022 at 2:35 PM Aurelien Jarno <aurelien@...el32.net> wrote:
> > >
> > > This commit fixes the error message
> > >
> > >   rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap
> >
> > The pipe grf only is used on the rk3588 device for this phy.
>
> Ok, looking at the code in details, I confirm that. Does it mean the
> change should be done at the phy driver level, to only look for
> rockchip,pipe-grf on the rk3588 device?

That would be reasonable, yes.

>
> --
> Aurelien Jarno                          GPG: 4096R/1DDD8C9B
> aurelien@...el32.net                 http://www.aurel32.net