linux-kernel - Re: [PATCH v3] hyperv: simplify and rename generate_guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220926095649.1f963340.olaf@aepfle.de>
Date:   Mon, 26 Sep 2022 09:56:49 +0200
From:   Olaf Hering <olaf@...fle.de>
To:     "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
Cc:     Li kunyu <kunyu@...china.com>, KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        Dexuan Cui <decui@...rosoft.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "hpa@...or.com" <hpa@...or.com>, "arnd@...db.de" <arnd@...db.de>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>
Subject: Re: [PATCH v3] hyperv: simplify and rename generate_guest_id

Sat, 24 Sep 2022 05:31:34 +0000 "Michael Kelley (LINUX)" <mikelley@...rosoft.com>:

> From: Olaf Hering <olaf@...fle.de> Sent: Friday, September 23, 2022 2:09 PM

> > A very long time ago I removed most usage of version.h AFAIR,
> Could you elaborate?

It is the cost of 'make LOCALVERSION=x' vs. 'make LOCALVERSION=y'.

Too many drivers will be recompiled for no good reason as of today.
I claim no consumer below drivers/ and sound/ has a valid usecase for version.h.
But, someone else has to take the energy and argue them out of the tree.

With the proposed change every consumer of asm-generic/mshyperv.h will be dirty,
see 'touch include/asm-generic/mshyperv.h' for the impact. Therefore I think
only the two existing c files should include this header, in case the provided
information has a true value for the consumer.


Olaf

Content of type "application/pgp-signature" skipped