linux-kernel - Re: [PATCH -next] wifi: brcmfmac: pcie: add missing pci_disable_device() in brcmf_pcie_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <521bf990-e6aa-ee95-fcfa-1a03d08ee766@huawei.com>
Date:   Mon, 26 Sep 2022 16:06:02 +0800
From:   Ruan Jinjie <ruanjinjie@...wei.com>
To:     Kalle Valo <kvalo@...nel.org>
CC:     Franky Lin <franky.lin@...adcom.com>, <aspriel@...il.com>,
        <hante.meuleman@...adcom.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <marcan@...can.st>, <linus.walleij@...aro.org>,
        <rmk+kernel@...linux.org.uk>, <soontak.lee@...ress.com>,
        <linux-wireless@...r.kernel.org>,
        <SHA-cyfmac-dev-list@...ineon.com>,
        <brcm80211-dev-list.pdl@...adcom.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] wifi: brcmfmac: pcie: add missing
 pci_disable_device() in brcmf_pcie_get_resource()



On 2022/9/26 15:58, Kalle Valo wrote:
> Ruan Jinjie <ruanjinjie@...wei.com> writes:
> 
>> On 2022/9/24 0:50, Franky Lin wrote:
>>> On Fri, Sep 23, 2022 at 2:42 AM ruanjinjie <ruanjinjie@...wei.com> wrote:
>>>>
>>>> Add missing pci_disable_device() if brcmf_pcie_get_resource() fails.
>>>
>>> Did you encounter any issue because of the absensent
>>> pci_disable_device? A bit more context will be very helpful.
>>>
>>
>> We use static analysis via coccinelle to find the above issue. The
>> command we use is below:
>>
>> spatch -I include -timeout 60 -very_quiet -sp_file
>> pci_disable_device_missing.cocci
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> 
> Please include this information to the commit log, it helps to
> understand the background of the fix.

 Thank you for your suggestion! I'll include this information in the
future commit log.

>