linux-kernel - Re: [PATCH] pinctrl: qcom: restrict drivers per ARM/ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <effa3125-3690-b4ab-066b-d4e37326c148@linaro.org>
Date:   Mon, 26 Sep 2022 10:14:07 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: restrict drivers per ARM/ARM64

On 25/09/2022 11:19, Krzysztof Kozlowski wrote:
> There is no point to allow selecting pin-controller drivers for Qualcomm
> ARMv7 SoCs when building ARM64 kernel, and vice versa.  This makes
> kernel configuration more difficult as many do not remember the Qualcomm
> SoCs.  There won't be a single image for ARMv7 and ARMv8/9 SoCs, so no
> features/options are lost.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   drivers/pinctrl/qcom/Kconfig | 38 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
> 
> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> index 2961b5eb8e10..bb1b4dd440d0 100644
> --- a/drivers/pinctrl/qcom/Kconfig
> +++ b/drivers/pinctrl/qcom/Kconfig
> @@ -15,6 +15,7 @@ config PINCTRL_MSM
>   config PINCTRL_APQ8064
>   	tristate "Qualcomm APQ8064 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -23,6 +24,7 @@ config PINCTRL_APQ8064
>   config PINCTRL_APQ8084
>   	tristate "Qualcomm APQ8084 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -31,6 +33,7 @@ config PINCTRL_APQ8084
>   config PINCTRL_IPQ4019
>   	tristate "Qualcomm IPQ4019 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -39,6 +42,7 @@ config PINCTRL_IPQ4019
>   config PINCTRL_IPQ8064
>   	tristate "Qualcomm IPQ8064 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -47,6 +51,7 @@ config PINCTRL_IPQ8064
>   config PINCTRL_IPQ8074
>   	tristate "Qualcomm Technologies, Inc. IPQ8074 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for
> @@ -57,6 +62,7 @@ config PINCTRL_IPQ8074
>   config PINCTRL_IPQ6018
>   	tristate "Qualcomm Technologies, Inc. IPQ6018 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for
> @@ -67,6 +73,7 @@ config PINCTRL_IPQ6018
>   config PINCTRL_MSM8226
>   	tristate "Qualcomm 8226 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -76,6 +83,7 @@ config PINCTRL_MSM8226
>   config PINCTRL_MSM8660
>   	tristate "Qualcomm 8660 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -84,6 +92,7 @@ config PINCTRL_MSM8660
>   config PINCTRL_MSM8960
>   	tristate "Qualcomm 8960 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -100,6 +109,7 @@ config PINCTRL_MDM9607
>   config PINCTRL_MDM9615
>   	tristate "Qualcomm 9615 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -108,6 +118,7 @@ config PINCTRL_MDM9615
>   config PINCTRL_MSM8X74
>   	tristate "Qualcomm 8x74 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -116,6 +127,7 @@ config PINCTRL_MSM8X74
>   config PINCTRL_MSM8909
>   	tristate "Qualcomm 8909 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -132,6 +144,7 @@ config PINCTRL_MSM8916
>   config PINCTRL_MSM8953
>   	tristate "Qualcomm 8953 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -152,6 +165,7 @@ config PINCTRL_MSM8976
>   config PINCTRL_MSM8994
>   	tristate "Qualcomm 8994 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -161,6 +175,7 @@ config PINCTRL_MSM8994
>   config PINCTRL_MSM8996
>   	tristate "Qualcomm MSM8996 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -169,6 +184,7 @@ config PINCTRL_MSM8996
>   config PINCTRL_MSM8998
>   	tristate "Qualcomm MSM8998 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -177,6 +193,7 @@ config PINCTRL_MSM8998
>   config PINCTRL_QCM2290
>   	tristate "Qualcomm QCM2290 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -185,6 +202,7 @@ config PINCTRL_QCM2290
>   config PINCTRL_QCS404
>   	tristate "Qualcomm QCS404 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -232,6 +250,7 @@ config PINCTRL_QCOM_SSBI_PMIC
>   config PINCTRL_SC7180
>   	tristate "Qualcomm Technologies Inc SC7180 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -241,6 +260,7 @@ config PINCTRL_SC7180
>   config PINCTRL_SC7280
>   	tristate "Qualcomm Technologies Inc SC7280 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -250,6 +270,7 @@ config PINCTRL_SC7280
>   config PINCTRL_SC7280_LPASS_LPI
>   	tristate "Qualcomm Technologies Inc SC7280 LPASS LPI pin controller driver"
>   	depends on GPIOLIB
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_LPASS_LPI
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -259,6 +280,7 @@ config PINCTRL_SC7280_LPASS_LPI
>   config PINCTRL_SC8180X
>   	tristate "Qualcomm Technologies Inc SC8180x pin controller driver"
>   	depends on (OF || ACPI)
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -268,6 +290,7 @@ config PINCTRL_SC8180X
>   config PINCTRL_SC8280XP
>   	tristate "Qualcomm Technologies Inc SC8280xp pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -277,6 +300,7 @@ config PINCTRL_SC8280XP
>   config PINCTRL_SDM660
>   	tristate "Qualcomm Technologies Inc SDM660 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -286,6 +310,7 @@ config PINCTRL_SDM660
>   config PINCTRL_SDM845
>   	tristate "Qualcomm Technologies Inc SDM845 pin controller driver"
>   	depends on (OF || ACPI)
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -295,6 +320,7 @@ config PINCTRL_SDM845
>   config PINCTRL_SDX55
>   	tristate "Qualcomm Technologies Inc SDX55 pin controller driver"
>   	depends on OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -304,6 +330,7 @@ config PINCTRL_SDX55
>   config PINCTRL_SM6115
>   	tristate "Qualcomm Technologies Inc SM6115,SM4250 pin controller driver"
>   	depends on GPIOLIB && OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -313,6 +340,7 @@ config PINCTRL_SM6115
>   config PINCTRL_SM6125
>   	tristate "Qualcomm Technologies Inc SM6125 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -322,6 +350,7 @@ config PINCTRL_SM6125
>   config PINCTRL_SM6350
>   	tristate "Qualcomm Technologies Inc SM6350 pin controller driver"
>   	depends on GPIOLIB && OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -331,6 +360,7 @@ config PINCTRL_SM6350
>   config PINCTRL_SM6375
>   	tristate "Qualcomm Technologies Inc SM6375 pin controller driver"
>   	depends on GPIOLIB && OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -340,6 +370,7 @@ config PINCTRL_SM6375
>   config PINCTRL_SDX65
>   	tristate "Qualcomm Technologies Inc SDX65 pin controller driver"
>   	depends on GPIOLIB && OF
> +	depends on ARM || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -349,6 +380,7 @@ config PINCTRL_SDX65
>   config PINCTRL_SM8150
>   	tristate "Qualcomm Technologies Inc SM8150 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	 This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -358,6 +390,7 @@ config PINCTRL_SM8150
>   config PINCTRL_SM8250
>   	tristate "Qualcomm Technologies Inc SM8250 pin controller driver"
>   	depends on OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -367,6 +400,7 @@ config PINCTRL_SM8250
>   config PINCTRL_SM8250_LPASS_LPI
>   	tristate "Qualcomm Technologies Inc SM8250 LPASS LPI pin controller driver"
>   	depends on GPIOLIB
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_LPASS_LPI
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -375,6 +409,7 @@ config PINCTRL_SM8250_LPASS_LPI
>   
>   config PINCTRL_SM8350
>   	tristate "Qualcomm Technologies Inc SM8350 pin controller driver"
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -384,6 +419,7 @@ config PINCTRL_SM8350
>   config PINCTRL_SM8450
>   	tristate "Qualcomm Technologies Inc SM8450 pin controller driver"
>   	depends on GPIOLIB && OF
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_MSM
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -393,6 +429,7 @@ config PINCTRL_SM8450
>   config PINCTRL_SM8450_LPASS_LPI
>   	tristate "Qualcomm Technologies Inc SM8450 LPASS LPI pin controller driver"
>   	depends on GPIOLIB
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_LPASS_LPI
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> @@ -402,6 +439,7 @@ config PINCTRL_SM8450_LPASS_LPI
>   config PINCTRL_SC8280XP_LPASS_LPI
>   	tristate "Qualcomm Technologies Inc SC8280XP LPASS LPI pin controller driver"
>   	depends on GPIOLIB
> +	depends on ARM64 || COMPILE_TEST
>   	depends on PINCTRL_LPASS_LPI
>   	help
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>